Configurable log level, plus settings documentation #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-tran
force-pushed
the
refactor/log-level
branch
from
0e3dac9 to
cbfb153
Compare
angela-tran
changed the title
angela-tran
force-pushed
the
refactor/log-level
branch
from
91ff2e9 to
85665de
Compare
thekaveman
reviewed
Aug 24, 2022
update documentation to reflect that this approach has slightly different behavior with the Flask debug flag.
angela-tran
force-pushed
the
refactor/log-level
branch
from
9fa9657 to
183a30e
Compare
thekaveman
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127 (configurable log level) and closes #107 (SUB_FORMAT_REGEX docs)
Initially, I only extracted the logging configuration and added documentation for the new
LOG_LEVELsetting. But then I noticed a lot of our settings were missing, so I went ahead and wrote out docs for all the available settings. I formatted it similarly to Benefit's Environment variables docs.