Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keypair configurable #135

Closed
Tracked by #608
thekaveman opened this issue Aug 23, 2022 · 0 comments · Fixed by #136
Closed
Tracked by #608

Make keypair configurable #135

thekaveman opened this issue Aug 23, 2022 · 0 comments · Fixed by #136
Assignees
Labels
security Changes to improve or maintain the availability and resilience of the app

Comments

@thekaveman
Copy link
Member

As part of moving this app towards production-ready, we need to be able to configure the keypair used as part of the Eligibility Verification token work.

We currently hardcode paths to the sample keys:

with open("./keys/server.key", "rb") as pemfile:
    server_private_key = jwk.JWK.from_pem(pemfile.read())
with open("./keys/client.pub", "rb") as pemfile:
    client_public_key = jwk.JWK.from_pem(pemfile.read())

Let's move these into a new couple of settings variables to allow them being overridden.

@thekaveman thekaveman added the security Changes to improve or maintain the availability and resilience of the app label Aug 23, 2022
@thekaveman thekaveman added this to the Courtesy Cards milestone Aug 23, 2022
@thekaveman thekaveman moved this to This Sprint (Month) in Digital Services Aug 23, 2022
@thekaveman thekaveman self-assigned this Aug 23, 2022
@thekaveman thekaveman moved this from This Sprint (Month) to In Progress in Digital Services Aug 24, 2022
Repository owner moved this from In Progress to Done in Digital Services Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Changes to improve or maintain the availability and resilience of the app
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant