Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump jwcrypto from 1.4.2 to 1.5.0 #66

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 31, 2023

Bumps jwcrypto from 1.4.2 to 1.5.0.

Release notes

Sourced from jwcrypto's releases.

v1.5.0

Version 1.5

Minor bugfixes and the addition of Brainpool curves. As mentioned in the commit: "The use of these algorithms is specified solely by the gematik GmbH – National Digital Health Agency - for use in german e-health applications"

This version also raises the minimum Cryptography version required to 3.4 and the minimum python version tested to 3.7

What's Changed

New Contributors

Full Changelog: latchset/jwcrypto@v1.4.2...v1.5.0

Commits
  • 41fb08a Version 1.5
  • db1f9f4 Add test to generate key with algorithm
  • e08cbf1 Use separate input_keysize property
  • 2fec703 Misc fixes and docstring corrections
  • 9f2cd3a Fix CI to run on the correct branch for main
  • dc21a78 Fix test to actually do what it should
  • 381c5d1 Fix codespell issue
  • 0c31ee0 Make linter happier about dummy exception
  • 4f6cf30 Python 3.6 is not available anymore in CI
  • 652afd9 Fix error message
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner May 31, 2023 07:58
@dependabot dependabot bot added the dependencies [auto] Pull requests that update dependencies label May 31, 2023
Bumps [jwcrypto](https://github.com/latchset/jwcrypto) from 1.4.2 to 1.5.0.
- [Release notes](https://github.com/latchset/jwcrypto/releases)
- [Commits](latchset/jwcrypto@v1.4.2...v1.5.0)

---
updated-dependencies:
- dependency-name: jwcrypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/jwcrypto-1.5.0 branch from ce6934a to de3b146 Compare June 20, 2023 19:25
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install updates

Outside the devcontainer

Checkout this branch and rebuild the devcontainer

Inside the devcontainer

Confirm package updates (edited for brevity / relevant packages)

$ pip freeze
...
jwcrypto==1.5.0

Run pytest

✅ All pytests passed locally

Inside the devcontainer

$ export PYTHONWARNINGS="default"
$ pytest
==================================================================== test session starts
platform linux -- Python 3.9.17, pytest-7.3.2, pluggy-1.0.0
rootdir: /home/calitp/src
plugins: mock-3.11.1, cov-4.1.0
collected 17 items
...
===================================================================== 17 passed in 0.43s

Additional manual tests

✅ Confirmed Agency Card verification (local benefits, local eligibility-server)

Configure server

Outside the devcontainer.

Replace the reference to eligibility-api in requirements.txt to point to this PR's commit:

git+https://github.com/cal-itp/eligibility-api.git@de3b146daef0f535e1a780e857f3c3290629e28b#egg=eligibility_api

Rebuild the image:

$ bin/build.sh

Configure Benefits

Outside the devcontainer.

See the note on this related PR review: cal-itp/eligibility-server#259 (review)

Ensure Benefits compose.yml points to the newly built eligibility_server:latest image

server:
  image: eligibility_server:latest

Update the reference to eligibility-api in pyprojecy.toml using the PEP508 format:

dependencies = [
  ...
  "eligibility_api @ git+https://github.com/cal-itp/eligibility-api.git@de3b146daef0f535e1a780e857f3c3290629e28b#egg=eligibility_api",
  ...
]

Rebuild the benefits image:

$ docker compose build client

Start the client and server:

$ docker compose up -d client server

Attach terminals to both running client and server to confirm they are using the updated package:

image

image

Confirm eligibility verification.

@thekaveman thekaveman merged commit fd28c29 into main Jun 20, 2023
@thekaveman thekaveman deleted the dependabot/pip/jwcrypto-1.5.0 branch June 20, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies [auto] Pull requests that update dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant