Gtfs loader v2 jsonification #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauriemerrell
force-pushed
the
gtfs-loader-v2-jsonification
branch
from
110fdd2 to
8335323
Compare
atvaccaro
suggested changes
Sep 2, 2022
airflow/dags/unzip_and_validate_gtfs_schedule/convert_to_json/METADATA.yml
Show resolved
Hide resolved
airflow/dags/unzip_and_validate_gtfs_schedule/convert_to_json/agency.yml
Outdated
Show resolved
Hide resolved
What do you mean? Like if >X% of outcomes are failures, we fail the job? Open to it but not sure what we'd set the threshold at |
|
Yeah really it's to catch situations where a bug broadly impacted the job and/or we think that the overall success rate is oddly low and worth "failing" the job. It can occur after the results upload so it's primarily something to bubble up through alerting. The downloader is 95%, maybe this could be similar? |
atvaccaro
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completes #1533, building on the work in #1696. Specifically, reads in files from unzipped GTFS downloads, converts them
jsonl, and saves thejsonlfiles in the same hive partitions as the input file & creates accompanying outcomes file.This PR does not create external tables for the JSONL data, that will be handled in #1536.
Resolves #1533
Type of change
How has this been tested?
Run in local Airflow for 8/12 (date that has test data available.)
Screenshots
Top two (existing) tasks manually marked as failures just to speed things up
