Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove agency index pass-thru #999

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

thekaveman
Copy link
Member

Closes #976... Although I realized in doing this that, it doesn't actually matter? We'll have a single agency with multiple verifiers, so this check would have failed anyway.

Oh well, it's dead code, so fine to remove.

the user will always stop on the agency index page
@thekaveman thekaveman requested a review from a team as a code owner October 4, 2022 02:08
@thekaveman thekaveman self-assigned this Oct 4, 2022
@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Oct 4, 2022
@thekaveman thekaveman enabled auto-merge October 4, 2022 02:09
@thekaveman thekaveman added this to the Courtesy Cards milestone Oct 4, 2022
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this check doesn't really make sense anymore

@thekaveman thekaveman merged commit 650bdb2 into dev Oct 4, 2022
@thekaveman thekaveman deleted the refactor/remove-agency-passthru branch October 4, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove agency index pass-through
2 participants