Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: enrollment success copy #997

Merged
merged 10 commits into from
Oct 5, 2022
Merged

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Oct 4, 2022

Closes #946

Closes #994 - I needed this to be able to add multiple paragraphs to the media list

Closes #1004 - added support for multiple paragraphs here anyway, it was an easy/small change to include

Before

image

After

MST CC verification

image

Login.gov verification

image

(note styling implementation is not finalized or addressed in this PR)

@thekaveman thekaveman added this to the Courtesy Cards milestone Oct 4, 2022
@thekaveman thekaveman self-assigned this Oct 4, 2022
@thekaveman thekaveman requested a review from a team as a code owner October 4, 2022 01:33
@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Oct 4, 2022
Comment on lines -11 to -17
{% if "logged-out" in page.classes %}
<img class="success-image" src="{% static "img/icon/happybus.svg" %}" alt="{% translate "core.icons.happybus" context "image alt text" %}">
{% else %}
<p>{% translate "enrollment.pages.success.p1" %}</p>
<p>{% translate "enrollment.pages.success.p2" %}</p>
<p>{% blocktranslate with help_link=help_link%}enrollment.pages.success.p3{{ help_link }}{% endblocktranslate %}</p>
{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need this logged out view?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thanks for this reminder, we talked about moving it out of the success view and I forgot to do that here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't actually make sense to move this out of the success view and create a specific "logged out" view - since the user can log out from various places in the app, we can't send them to a final "you are logged out" everytime they log out - we use the session.origin() to know where to send the user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 6f0db24

avoid rendering HTML when no media items
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run DJANGO_LOAD_SAMPLE_DATA=true bin/init.sh before testing.

image

And the empty media item spacing issue is also fixed 👍

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR, after it is merged, the full Login.gov flow and signing out of it should be checked on dev-benefits.calitp.org/ to double-check the logged out page looks okay.

@thekaveman
Copy link
Member Author

I am going to prep the data migrations before merging so I don't break dev. Will aslo post a working localhost migration that we can all use for testing against the Login sandbox + our local test server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
3 participants