Eligibility Confirm: Update copy, add form input helper text #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in English and Spanish; add TODO for Sub placeholder
github-actions
bot
added
i18n
angela-tran
approved these changes
Sep 27, 2022
1 task
thekaveman
reviewed
Sep 27, 2022
| @@ -146,9 +146,11 @@ def load_sample_data(app, *args, **kwargs): | |||
| form_content_title=_("eligibility.pages.confirm.mst.content_title"), | |||
| form_blurb=_("eligibility.pages.confirm.mst.p[0]"), | |||
| form_sub_label=_("eligibility.forms.confirm.mst.fields.sub"), | |||
| form_sub_placeholder="B1234567", | |||
| form_sub_help_text=_("eligibility.forms.confirm.mst.fields.sub.help_text"), | |||
| form_sub_placeholder="TODO: B1234567", | |||
There was a problem hiding this comment.
I think we can make this #12345 based on design discussions
There was a problem hiding this comment.
But this raises an interesting question - we don't have the # symbol in the data we'll get from Velocity. So we may need to strip it out here before sending to the Server?
|
Forgot to note earlier: if we haven't already, we should update data migrations in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #944
What this PR does
form_sub_help_text,form_sub_name_textto initial migration, sample data, model and conftest for testingmst.fields.sub.help_textandmst.fields.name.help_textin English and TODO for SpanishTODOfor placeholder, to remind us to update the placeholder for sub form inputWhen testing this PR
Remember to run
./bin/init.shScreenshots
http://localhost:11369/eligibility/confirm
English
Spanish
