-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verifier Selection: Update copy, add link #951
Conversation
…r Senior Discount Program, update English copy
…n href link and parse as html
Paired with @angela-tran to figure out how to use to pass variables from the Python class and get the Django template to parse it as HTML in the Page template: def my_view(request, m, d):
output = _('Today is %(month)s %(day)s.') % {'month': m, 'day': d}
return HttpResponse(output) Landed on: format_html(_("eligibility.pages.index.p[0]%(info_link)s") % {"info_link": help_page}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks right on track! I left a few comments about some things to resolve.
@machikoyasuda would you like me to rebase this on the |
Ready for re-review @angela-tran @thekaveman |
Co-authored-by: Kegan Maher <[email protected]>
Co-authored-by: Angela Tran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job
closes #939
What this PR does
eligibility.pages.index.p[0]
eligibility.pages.index.dmv.label
,mst.label
,mst.description
,content_title
,button
eligibility.pages.index.dmv.description
dmv.description
content_title
What this PR does not do
Details on the Radio Button Label
Semantically and HTML-wise, the
Select...
text is the label of the form. It is the same element as the label of the form inputs on the Courtesy Card form page.Design-wise, the
Select...
text is in the style of an H2. In future PRs, we will have to write code that distinguishes a label of a form from this Verifier page vs. the Courtesy Card Enrollment page, and style them differently.Screenshots
English
Spanish