Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier Selection: Update copy, add link #951

Merged
merged 18 commits into from
Sep 28, 2022
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Sep 23, 2022

closes #939

What this PR does

  • Adds new paragraph to the page: eligibility.pages.index.p[0]
  • Updates copy for eligibility.pages.index.dmv.label, mst.label, mst.description, content_title, button
  • Sets Eligibility Verifier 1 to have a eligibility.pages.index.dmv.description
  • Adds dmv.description
  • Adds new label (but styled as a H2 on figma)
  • Spanish copy
  • Add link to content_title

What this PR does not do

  • Change django.po keys (mst vs. dmv)
  • CSS

Details on the Radio Button Label

Semantically and HTML-wise, the Select... text is the label of the form. It is the same element as the label of the form inputs on the Courtesy Card form page.
image

Design-wise, the Select... text is in the style of an H2. In future PRs, we will have to write code that distinguishes a label of a form from this Verifier page vs. the Courtesy Card Enrollment page, and style them differently.
image

Screenshots

English
image

Spanish
image

…r Senior Discount Program, update English copy
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework labels Sep 23, 2022
@machikoyasuda machikoyasuda self-assigned this Sep 23, 2022
@machikoyasuda machikoyasuda added this to the Courtesy Cards milestone Sep 23, 2022
@machikoyasuda machikoyasuda linked an issue Sep 23, 2022 that may be closed by this pull request
1 task
Base automatically changed from feat/cc-one-col to dev September 26, 2022 16:19
@machikoyasuda machikoyasuda marked this pull request as ready for review September 27, 2022 18:46
@machikoyasuda machikoyasuda requested a review from a team as a code owner September 27, 2022 18:46
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Sep 27, 2022

Paired with @angela-tran to figure out how to use to pass variables from the Python class and get the Django template to parse it as HTML in the Page template:

def my_view(request, m, d):
    output = _('Today is %(month)s %(day)s.') % {'month': m, 'day': d}
    return HttpResponse(output)

Landed on:

format_html(_("eligibility.pages.index.p[0]%(info_link)s") % {"info_link": help_page})

@machikoyasuda machikoyasuda changed the title Verifier selection page: Copy only Verifier Selection: Copy Sep 27, 2022
@machikoyasuda machikoyasuda changed the title Verifier Selection: Copy Verifier Selection: Update copy, add link Sep 27, 2022
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks right on track! I left a few comments about some things to resolve.

benefits/eligibility/views.py Outdated Show resolved Hide resolved
benefits/core/views.py Outdated Show resolved Hide resolved
benefits/eligibility/forms.py Show resolved Hide resolved
@thekaveman
Copy link
Member

I suggest we get #956 and #958 in before this one. I can help with rebasing these changes onto those two sets once they are in. I really want to drop dmv entirely from everything.

@thekaveman
Copy link
Member

@machikoyasuda would you like me to rebase this on the dev changes?

@machikoyasuda
Copy link
Member Author

Ready for re-review @angela-tran @thekaveman

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@machikoyasuda machikoyasuda merged commit 4748d8f into dev Sep 28, 2022
@machikoyasuda machikoyasuda deleted the feat/verifier--copy branch September 28, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update copy / content blocks on verifier selection page
3 participants