Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: 500 page #928

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Refactor: 500 page #928

merged 2 commits into from
Sep 23, 2022

Conversation

angela-tran
Copy link
Member

Closes #916

Builds off changes from #914.

Before After
image image

@angela-tran angela-tran added this to the Courtesy Cards milestone Sep 20, 2022
@angela-tran angela-tran requested a review from a team as a code owner September 20, 2022 22:21
@angela-tran angela-tran self-assigned this Sep 20, 2022
@github-actions github-actions bot added the i18n Copy: Language files or Django i18n framework label Sep 20, 2022
@angela-tran angela-tran changed the base branch from dev to refactor/error-page-layout-and-wording September 20, 2022 22:21
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed front-end HTML/CSS/JavaScript and Django templates labels Sep 20, 2022
thekaveman
thekaveman approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good too!

Base automatically changed from refactor/error-page-layout-and-wording to dev September 21, 2022 19:50
@machikoyasuda machikoyasuda self-requested a review September 21, 2022 20:16
machikoyasuda
machikoyasuda approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Checked in Spanish and English for 500 pages

@angela-tran
Copy link
Member Author

Thanks @machikoyasuda ! The Spanish translation strings in your screenshot look out-of-date. You can re-compile the language files and get the latest strings with ./bin/init.sh.
image

@angela-tran angela-tran reopened this Sep 23, 2022
@angela-tran angela-tran merged commit f85c822 into dev Sep 23, 2022
@angela-tran angela-tran deleted the refactor/500-page branch September 23, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees

@angela-tran angela-tran

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Courtesy Cards
Development

Successfully merging this pull request may close these issues.

Use 500 page for true application errors
3 participants
@angela-tran @thekaveman @machikoyasuda