Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): return Group ID with Returned Success #897

Merged
merged 6 commits into from
Sep 7, 2022
Merged

feat(analytics): return Group ID with Returned Success #897

merged 6 commits into from
Sep 7, 2022

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Sep 6, 2022 •
edited
Loading

closes #890

Passes eligibility.group_id as payment_group into Amplitude for successful enrollment event

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. and removed tests Related to automated testing (unit, UI, integration, etc.) labels Sep 6, 2022
@machikoyasuda machikoyasuda self-assigned this Sep 6, 2022
@machikoyasuda machikoyasuda added this to the Courtesy Cards milestone Sep 6, 2022
@machikoyasuda machikoyasuda marked this pull request as ready for review September 6, 2022 20:47
@machikoyasuda machikoyasuda requested a review from a team as a code owner September 6, 2022 20:47
thekaveman
thekaveman requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't notice this before:

The ReturnedEnrollmentEvent class needs to be updated too, to accept the new parameter (maybe with a default of None) and then make a call to self.update_event_properties() if there is a value.

@thekaveman thekaveman added the analytics App event tracking, instrumentation, logging: Metabase, Amplitude label Sep 6, 2022
thekaveman
thekaveman approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@machikoyasuda machikoyasuda merged commit 4267f16 into dev Sep 7, 2022
@machikoyasuda machikoyasuda deleted the feat/890-enrollment-success-payment-group branch September 7, 2022 19:18
@machikoyasuda machikoyasuda mentioned this pull request Sep 14, 2022
Merged
@thekaveman thekaveman mentioned this pull request Dec 7, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
analytics App event tracking, instrumentation, logging: Metabase, Amplitude back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Milestone
Courtesy Cards
Development

Successfully merging this pull request may close these issues.

Add group information to enrollment success event
2 participants
@machikoyasuda @thekaveman