Chore: init deletes existing db #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid unnecessary warning message about pending migrations since we want to rebuild the database from scratch anyway
github-actions
bot
added
deployment-dev
machikoyasuda
approved these changes
Jun 9, 2022
angela-tran
approved these changes
Jun 9, 2022
thekaveman
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another area that can trip up new devs (and, me...:blush:), especially with all the extra warning messages that can be printed. Then if you have a mismatch in data/migrations and existing schema there can be all kinds of annoying errors.
In development mode, it's nice (e.g. when the devcontainer starts) to have the init script clear out any existing database file before rebuilding the whole thing.
In production, this should be a noop since the database file won't exist yet.