-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump actions/setup-python from 3 to 4 #652
chore(deps): bump actions/setup-python from 3 to 4 #652
Conversation
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3 to 4. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this update, the pre-commit
check is failing with a strange message:
Error: The specified python version file at: /home/runner/work/benefits/benefits/.python-version does not exist
From the release notes https://github.com/actions/setup-python/pull/336Looks like we this is a breaking change that requires this version file or filepath to be added. |
Thank you @machikoyasuda for finding this!! 🙏 Kind of annoying to get a broken Dependabot update... Seems like we should use the |
actions/setup-python@v4 requires either a python-version or python-version-file param (there is no default version) use python-version-file so we can point to a common file in multiple workflows
5872b52
to
126a0a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this approach but would appreciate another set of eyes 🦅 👁️
Bumps actions/setup-python from 3 to 4.
Release notes
Sourced from actions/setup-python's releases.
... (truncated)
Commits
d09bd5e
fix: 3.x-dev can install a 3.y version (#417)f72db17
Made env.var pythonLocation consistent for Python and PyPy (#418)53e1529
add support for python-version-file (#336)3f82819
Fix output for prerelease version of poetry (#409)397252c
Update zeit/ncc to vercel/ncc (#393)de977ad
Merge pull request #412 from vsafonkin/v-vsafonkin/fix-poetry-cache-test22c6af9
Change PyPy version to rebuild cache081a3cf
Merge pull request #405 from mayeut/interpreter-pathff70656
feature: add apython-path
outputfff15a2
Use pypyX.Y for PyPy python-version input (#349)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)