-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump cypress from 9.7.0 to 10.0.2 in /tests/cypress #634
chore(deps-dev): bump cypress from 9.7.0 to 10.0.2 in /tests/cypress #634
Conversation
Bumps [cypress](https://github.com/cypress-io/cypress) from 9.7.0 to 10.0.2. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js) - [Commits](cypress-io/cypress@v9.7.0...v10.0.2) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
I ran Cypress locally (outside of VS Code Remote Containers) so I could use the UI. The new upgraded UI has some improvements: being able to see the screen in a larger view, being able to see the files in a tree format, and general UI redesign updates. It is easier to switch browsers from Chrome, Firefox to Electron. The test runs seem much faster overall and the visuals also render faster. I ran through the Migration Guide, which looked like this: All spec files had to be renamed. More details in the docs here: https://docs.cypress.io/guides/references/migration-guide#Updated-Test-File-Locations And then their first-time onboarding flow: Having to choose End to End versus Component testing is a new step. Running specs in the UI for Chrome and Electron: Firefox UI looked a little buggy (the top 100px or so is obscured) and had a test fail (Spanish language) that didn't fail on Chrome. Tested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this from my side. @thekaveman @angela-tran It would be great if either of you could test this whole PR locally on your end too, to ensure the tests run and pass locally for y'all after the 2 migration work commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inside the devcontainer, I checked out this branch then:
npm ci
to install updated version of npm package(s)npx cypress install
to initialize the new CypressF5
to launch the Benefits appCYPRESS_baseUrl=http://localhost:8000 npm run cypress:ui
to run UI tests (they all passed ✅)
Interestingly, from my host machine I wasn't able to get the tests to pass! It seems like Cypress couldn't get to the configured CYPRESS_baseUrl
even though the app was live. This was the same with npm run cypress:ui
and npm run cypress:open
- couldn't make a request to localhost.
Anyway, looks good to me!
Bumps cypress from 9.7.0 to 10.0.2.
Release notes
Sourced from cypress's releases.
Commits
9407d07
release 10.0.2 [skip ci]309c31f
fix: changes to correct typescript detection behavior (#22058)3b5a245
fix: sanitize internal vite plugins (#22055)e170d5d
fix: do not watch specs on run mode (#22060)b83bdc2
fix: #22038 support esm import for windows (#22042)a0a64cc
fix: Change ffmpeg to post process at priority 20 (#21587)9cdab56
chore: enable runner to be rebuild with general watcher (#21664)013501c
release 10.0.1 [skip ci]ea3cd7f
Merge branch 'master' into develop9caf623
fix: do not show incorrectly support file migration step (#22015)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)