Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrollment Success: Swap out success image #628

Merged
merged 1 commit into from
May 26, 2022

Conversation

machikoyasuda
Copy link
Member

closes #627

What this PR does

  • Use happybus.svg instead
  • Delete success.svg
  • Resize svg (150px by 150px)
  • Use 15% margin-top (percentage rather than pixels, to be more responsive)

Screenshots

image

image

image

@machikoyasuda machikoyasuda changed the title feat(enrollment success): Enrollment Success: Swap out success image May 26, 2022
@github-actions github-actions bot added the deployment-dev [auto] Changes that will trigger a deploy if merged to dev label May 26, 2022
@machikoyasuda machikoyasuda marked this pull request as ready for review May 26, 2022 18:18
@machikoyasuda machikoyasuda requested a review from a team as a code owner May 26, 2022 18:18
@machikoyasuda machikoyasuda added this to the Login.gov SSO milestone May 26, 2022
@machikoyasuda machikoyasuda self-assigned this May 26, 2022
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@machikoyasuda machikoyasuda merged commit ee34750 into dev May 26, 2022
@machikoyasuda machikoyasuda deleted the fix/627-enrollment-success--image branch May 26, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrollment Success Page: Change image
2 participants