Refactor: remove jwcrypto #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
|
@thekaveman I saw your comment on cal-itp/eligibility-api#31. This PR will definitely change due to that, so please ignore its current state! Thanks 🙏 |
angela-tran
commented
May 24, 2022
the API expects to accept the public/private keys as in raw data form, either as a string or a bytes-like object.
angela-tran
force-pushed
the
refactor/remove-jwcrypto
branch
from
7e0f6c7 to
8cec392
Compare
thekaveman
reviewed
May 26, 2022
thekaveman
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #617
Reviewing this PR
eligibility-apipackage is installed by either:clientimage and the devcontainerpip install -r requirements.txt(runpip uninstall eligibility-apifirst if you previously installed it and want to re-install it)tests/pytest/eligibility/test_views.pyto see that eligibility verification still works