Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: devcontainer command syntax #352

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix: devcontainer command syntax #352

merged 1 commit into from
Mar 31, 2022

Conversation

thekaveman
Copy link
Member

Fixes #351

@thekaveman thekaveman force-pushed the fix/devcontainer-cmd branch from 5446451 to 472e29f Compare March 29, 2022 00:22
@thekaveman
fix(devcontainer): use list syntax and command opt
fa1b41e 
in newer versions of Docker/Compose, the devcontainer command
syntax was broken, causing an error like:

    > /bin/sleep: /bin/sleep: cannot execute binary file

the list syntax allows us to pass the "-c" option first,
forcing bash to interpret the remaining args as the command

see https://stackoverflow.com/a/62313159
@thekaveman thekaveman force-pushed the fix/devcontainer-cmd branch from 472e29f to fa1b41e Compare March 31, 2022 17:00
@angela-tran
Copy link
Member

I'm currently having issues with opening the devcontainer when I'm on branch fix/devcontainer-cmd. That was on my older version of Docker Desktop (4.5.1), and I've now tried with the latest version as well. Still seeing errors.

image
image

The devcontainer does open for me when I'm on the dev branch.
image

@thekaveman
Copy link
Member Author

thekaveman commented Mar 31, 2022 •
edited
Loading

@angela-tran that error looks similar from yesterday.

In Docker Desktop, Delete the benefits_devcontainer group (or one by one if that doesn't work)

image

Then locally,

docker compose build --no-cache client

Then

docker compose build --no-cache dev

And finally Reopen in Container... that should work?

note the server will likely fail, see notes in #378

@angela-tran
Copy link
Member

I see the same behavior as you now @thekaveman - it was right after I went into Docker Desktop > Settings > General, and checked "Use Docker Compose V2".

image

Now the devcontainer opens for me on fix/devcontainer-cmd but not on dev.

@thekaveman thekaveman merged commit 856eb40 into dev Mar 31, 2022
@thekaveman thekaveman deleted the fix/devcontainer-cmd branch March 31, 2022 19:39
@thekaveman thekaveman mentioned this pull request Apr 12, 2022
Merged
@thekaveman thekaveman added this to the Dev environment cleanups milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@angela-tran angela-tran angela-tran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Dev environment cleanups
Development

Successfully merging this pull request may close these issues.

Fix devcontainer command syntax
3 participants
@thekaveman @angela-tran @machikoyasuda