Refactor: multiple verifiers in language files #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deployment-dev
thekaveman
force-pushed
the
refactor/language-files
branch
from
41bdb32 to
f573b87
Compare
different msgids, other values for each wire to test agency ABC
it isn't actually supported to have multiple
make sure they are translated on the form
thekaveman
force-pushed
the
refactor/language-files
branch
from
f573b87 to
9b2ff5a
Compare
these need to be rewritten to handle the new flow with verifier selection screen
4 tasks
angela-tran
reviewed
Mar 25, 2022
There was a problem hiding this comment.
That's a bummer we can't have multiple files for a language. The msgids you came up with for each verifier look good though! 💥
I just have the one question about eligibility.pages.start.mst.p[0].
I also noticed a bug while following the "Testing" steps in #338, but it's unrelated to these changes, so I created issue #346.
angela-tran
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338
✅ Can be rebased on
devonce #337 is merged to incorporate those changes as well.