-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: EligibilityVerifier custom text #331
Conversation
7781e29
to
450417d
Compare
these will store the msgid for translation.
these will store the msgid for translation.
these will store the msgid for translation.
This is because the selection description is optional.
450417d
to
c87d7fd
Compare
Before we merge this, we have to update the fixture file(s) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rename the fields I had added previously, to line up with the new ones you're adding (which I like better):
form_sub_pattern
(instead ofregex
)form_name_max_length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing too - this is going to run migrations and create the fields, but the fixtures aren't updated to contain the new data. I updated the ticket with a new task for this.
Populate the fixture with existing msgids from our .po files.
6ed42f3
to
984bf73
Compare
I like that better too. Made this change in 7ed9492. Note that I also reordered the fields in the model definition and fixtures to group them better. I left the order alone in the migration code to keep my changes minimal. |
Made this change in 984bf73. Some notes:
|
Some open questions came up when I was looking at the PO entries. We could resolve them either as a part of this PR or as separate tickets/PRs. I noted the questions in the ticket (#319). |
Rename 'instructions_title' and 'form_title' fields to be more consistent with msgid.
@thekaveman I updated the description in #319 and made those changes. This is ready for re-review 🔍 |
@angela-tran Looking at this again 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I cleaned the compiled language files and rebuilt my local database; no reported errors, the migrations run, fixtures are imported, and language files compiled:
calitp@93063145f6a8 ~/app (feat/verifier-custom-text)
$ rm django.db
calitp@93063145f6a8 ~/app (feat/verifier-custom-text)
$ rm benefits/locale/**/*.mo
calitp@93063145f6a8 ~/app (feat/verifier-custom-text)
$ bin/init.sh
[21/Mar/2022 23:38:46] DEBUG benefits.core.urls:41 Register path converter: TransitAgencyPathConverter
[21/Mar/2022 23:38:46] DEBUG benefits.urls:34 Skip url registrations for admin
Operations to perform:
Apply all migrations: core, sessions
Running migrations:
Applying core.0001_initial... OK
Applying sessions.0001_initial... OK
[21/Mar/2022 23:38:47] DEBUG benefits.core.urls:41 Register path converter: TransitAgencyPathConverter
[21/Mar/2022 23:38:47] DEBUG benefits.urls:34 Skip url registrations for admin
Installed 9 object(s) from 5 fixture(s)
superuser: Django not configured for Admin access
processing file django.po in /home/calitp/app/benefits/locale/en/LC_MESSAGES
processing file django.po in /home/calitp/app/benefits/locale/es/LC_MESSAGES
Launching the local app with F5
I can successfully verify a test user:
Closes #319