Refactor: read custom Content Security Policy config from env #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helper removes empty items from split lists
github-actions
bot
added
the
deployment-dev
machikoyasuda
requested changes
Jan 24, 2022
need to be able to load external styles so Lighthouse tests don't fail the accessibility checks (for e.g. bad color contrast ratio)
angela-tran
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
These changes look good to me 👍 Definitely makes it easier to update those settings.
Props to @machikoyasuda for mentioning the Lighthouse errors!
machikoyasuda
approved these changes
Jan 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes updates to deployed apps easier, since we can just update the environment and restart - vs. having to change the code and redeploy.
.envfile with the new settings. Add the values that were previously hard-coded insettings.pyusing the new environment variables introduced in this PR.