Simplify and cleanup API interactions #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the value in session is just the name
Contrary to the docs, when updating an existing customer record, the customer's ID property is not passed back with the response. Group registration requires a customer ID, so inject into response when we know it ahead of time (since the customer exists).
we may need this in the future, but as of now it is bringing more overhead and complexity than it's worth
remove unneeded base Response class, raise exceptions instead
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeling Agencies as having only a single Eligibility Verifier (instead of a list) simplifies the initial call to EV.
With liberal use of a few custom Exception classes, we can further eliminate all the type checking and special handling for API responses, where we would just raise an exception (or one would be raised) anyway.
In the Discounts API, we also need to carry the
customer_idbetween calls as it's not currently being returned in an update/PATCH request.