Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reCAPTCHA: Fix Unverified error pages #2597

Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 18, 2024

closes #2596

What this PR does

  • Creates a way the unverified-error-agency-card-base.html error template for the unverified error for Agency Card templates: The headline, icon, CTA, agency links, back button all come from the template. The agency-card-specific template only now brings in the body paragraph.
  • And now unverified.html is only for the Login/Non-Login (non-agency card) error flow.

How to test

  • You can go directly to eligibility/unverified after you chose an agency and compare with the error page on prod

@machikoyasuda machikoyasuda self-assigned this Dec 18, 2024
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@machikoyasuda machikoyasuda marked this pull request as ready for review December 18, 2024 23:52
@machikoyasuda machikoyasuda requested a review from a team as a code owner December 18, 2024 23:52
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks good. Just need to make the button go back to the form

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@machikoyasuda machikoyasuda merged commit 1561cb5 into refactor/recaptcha-copy Jan 2, 2025
8 checks passed
@machikoyasuda machikoyasuda deleted the fix/recaptcha-unverified-errors branch January 2, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agency Card Eligibility Error screen has incorrect headline copy and button
2 participants