-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reCAPTCHA: Fix Unverified error pages #2597
Merged
machikoyasuda
merged 6 commits into
refactor/recaptcha-copy
from
fix/recaptcha-unverified-errors
Jan 2, 2025
Merged
reCAPTCHA: Fix Unverified error pages #2597
machikoyasuda
merged 6 commits into
refactor/recaptcha-copy
from
fix/recaptcha-unverified-errors
Jan 2, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machikoyasuda
added this to the Benefits app frontend enhancements and optimization milestone
Dec 18, 2024
github-actions
bot
added
front-end
HTML/CSS/JavaScript and Django templates
i18n
Copy: Language files or Django i18n framework
labels
Dec 18, 2024
10 tasks
angela-tran
requested changes
Dec 19, 2024
…x copy for unverified login/nonlogin
angela-tran
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy looks good. Just need to make the button go back to the form
benefits/eligibility/templates/eligibility/unverified-error-agency-base.html
Outdated
Show resolved
Hide resolved
angela-tran
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2596
What this PR does
unverified-error-agency-card-base.html
error template for the unverified error for Agency Card templates: The headline, icon, CTA, agency links, back button all come from the template. The agency-card-specific template only now brings in the body paragraph.unverified.html
is only for the Login/Non-Login (non-agency card) error flow.How to test
eligibility/unverified
after you chose an agency and compare with the error page on prod