-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: reCAPTCHA copy + redesign #2572
Merged
Merged
Changes from all commits
Commits
Show all changes
114 commits
Select commit
Hold shift + click to select a range
e2163eb
refactor: remove icons from showing up in media items
angela-tran 4181328
refactor: remove bankcardcheck icon and now unused icon blocks
angela-tran a79563f
refactor: remove idcardcheck icon and now unused icon blocks
angela-tran d52b343
refactor: rename template filenames that contained `bankcardcheck`
angela-tran c3f63cc
refactor: rename template filenames that contained `idcardcheck`
angela-tran ea9f790
Refactor(reCAPTCHA): remove icons (#2564)
angela-tran 0ed1e18
feat(recaptcha): all H1s are now left-aligned on desktop and mobile
machikoyasuda a10e1ac
feat(recaptcha): convert elig page to all col-lg-6
machikoyasuda eb69d78
feat(recaptcha): eligibility - remove 64px margin from all agency ind…
machikoyasuda d844dec
refactor(css): use class to position, instead of declaring styles
machikoyasuda e945960
refactor(css): use gap-4 (24px), gap-md-3 (16px); bump up 15px to 16px
machikoyasuda 1342b24
refactor: remove unused css class
machikoyasuda 2ed9222
reCAPTCHA: Eligibility index page - Align page and refactor (#2570)
machikoyasuda 9f61a3e
feat(elig-start): recaptcha - first pass @ col-lg-6 for text and button
machikoyasuda bf2825a
refactor: eliminate unnecessary div
machikoyasuda 4d0a733
feat(elig-start): widen cta, narrow text for all eligibility start op…
machikoyasuda 207b849
feat(elig-start): widen cta, narrow text for agency card
machikoyasuda 64c3c31
refactor: an attempt to refactor media-item css
machikoyasuda 00f3f38
fix(css): create list-disc class instead
machikoyasuda 6e16a2e
refactor(media-item): delete unnecessary classes, divs in media-item
machikoyasuda b2b91f1
refactor(elig-start): remove unnecessary class, div from all id media…
machikoyasuda f41cb98
feat(css): first pass @ get started with login.gov button
machikoyasuda e27350b
refactor(media-item): remove unused header-wrapper, media-body div/class
machikoyasuda ed39e8c
fix(css): update h2-sm-p comment
machikoyasuda 00cc296
fix(enrollment-index-calfresh): add list-unstyled, remove media-item …
machikoyasuda c90f30c
reCAPTCHA: Eligibility Start (#2573)
machikoyasuda 2b50e4b
feat(enrollment-success): widen header to 9, to match content
machikoyasuda 31722ca
feat(logged-out): update logged out page with new spacing
machikoyasuda 45351bd
feat(enrollment-success): don't forget cta log out sentence
machikoyasuda 9059962
refactor: reduce divitis on enrollment-success
machikoyasuda 32d41d4
feat(copy): remove <br> from headings
machikoyasuda f2ca459
feat(enrollment-index): use col-lg-6 for heading, content and set bas…
machikoyasuda 2eb8197
feat(enrollment-index-calfresh): realign calfresh enrollment index, r…
machikoyasuda d559c19
fix(enrollment-index-agency-card): remove large padding bottom
machikoyasuda e187a60
refactor(media-item): rename media-item to info, remove unnecessary u…
machikoyasuda 56b9322
refactor(media-item): remove template entirely, render content direct…
machikoyasuda aab7c0c
reCAPTCHA: Enrollment index (#2575)
machikoyasuda 30edfda
refactor(elig-start): use call-to-action-button for block, not the pa…
machikoyasuda 0a5f154
refactor(eligibility-item): rename media-item template to eligibility…
machikoyasuda ff88efa
refactor(elig-item): rename all files from media-item to eligibility-…
machikoyasuda cf11c04
refactor(elig-start): add h1 styling to start.html
machikoyasuda 279fc00
fix(logged-out): fix padding from top
machikoyasuda 7404a9d
Fix/Refactor: Eligibility Start (#2583)
machikoyasuda 9edb893
reCAPTCHA: Enrollment Success, Logged Out (#2579)
machikoyasuda d881a12
chore(pre-commit): run autofix
machikoyasuda 7a4e5fb
chore(pre-commit): run autofix (#2589)
machikoyasuda fa88233
feat(error-template): realign error template for 200 error, 400, 404,…
machikoyasuda e55fd29
feat(oauth-error): realign oauth system error page
machikoyasuda 01112e9
feat(reenrollment-calfresh): realign template for reenrollment error …
machikoyasuda 9a9c646
fix: remove unnecessary outer div, provided by base
machikoyasuda 8a301c6
feat(enrollment-error): realign template, update css for enrollment s…
machikoyasuda 2acaf46
feat(enrollment-retry): realign template for reenrollment retry error
machikoyasuda 732f794
feat(elig-unverified): realign eligibility unverified error page
machikoyasuda f2f7358
refactor(templates): move log out button into nav-buttons
machikoyasuda a85e8d9
refactor(error): all error pages now extend error
machikoyasuda 4e6eeab
refactor: rename error to error-base, for consistency
machikoyasuda 5b91916
test(models): update test_tempate_path spec
machikoyasuda 9ed5091
refactor(oauth-error): remove unnecessary button call, inherited from…
machikoyasuda 46fd496
refactor(error-base): loading i18n not necessary
machikoyasuda 2a69f17
refactor(error-base): remove redundant title call and use page-title …
machikoyasuda 812446c
refactor(error-base): set sad bus icon as the default icon
machikoyasuda cb558f4
feat(help): realign Help page width, combine some divs
machikoyasuda 54fb16f
fix: remove unnecessary class
machikoyasuda 2a7d08f
reCAPTCHA: Help page (#2584)
machikoyasuda 4c188bf
reCAPTCHA: Error pages (#2585)
machikoyasuda d81de3e
feat(elig-index): create recaptcha-text, add spanish, add to elig index
machikoyasuda 8a5d4cd
refactor(form): put recaptcha link in form instead
machikoyasuda 32c9297
fix(form): fix alignment of recaptcha, was slightly too wide
machikoyasuda 7a81aab
fix(elig-confirm): form does not need to be wrapped in container/row
machikoyasuda d331ca6
feat(recaptcha-text): add text styling, add icon size styling
machikoyasuda 129d108
fix(recaptcha-text): don't link the Google part, for En and Es
machikoyasuda 128d28a
feat(recaptcha): hide the badge with CSS
machikoyasuda 29dad70
fix(recaptcha-text): add mt-0 to reset margin-top from bootstrap
machikoyasuda 7479af3
refactor: refactor form to allow for a mb-fix that shortens space und…
machikoyasuda 5d34bb4
fix: update comment to proper classname
machikoyasuda 9cfd2c6
refactor(css): use a footer style rather than negative margin hack
machikoyasuda a4e9b6f
refactor(css): variable-ize external link icon size
machikoyasuda 1f2ee3e
fix(css): contain icon size
machikoyasuda 87f40f7
docs: add clarifying comments
machikoyasuda b21f806
fix(recaptcha): use display none on badge
machikoyasuda 986fc6f
fix(css): remove 24px footer margin from elig-confirm
machikoyasuda ec05326
fix: remove unnecessary class
machikoyasuda dce769c
fix(form): undo form refactoring for now
machikoyasuda 14bcb1a
fix(unverified): set up unverified-base to be inherited by unverified…
machikoyasuda d8dd84d
chore: make messages
machikoyasuda 2ef3421
fix(unverified): undo filename changes
machikoyasuda 635c638
fix(unverified): create separate base for unverified agency cards, fi…
machikoyasuda 6cb906f
fix(unverified): add back Spanish unverified error copy for Login/non…
machikoyasuda b4e56f5
fix(unverified): button goes back to form, not home
machikoyasuda 1561cb5
reCAPTCHA: Fix Unverified error pages (#2597)
machikoyasuda 69b7cc8
chore: merge feature branch
machikoyasuda 18bea68
reCAPTCHA: Add reCAPTCHA text, hide flag on Elig Index, Elig Confirm …
machikoyasuda 66dc6f8
feat(css): change 70px to 72px above h1
machikoyasuda abf22f7
refactor(base): refactor headline block to have col-lg-6 in it
machikoyasuda a2955f8
refactor(base): remove now unnecessary col-lg-8 wrapper in explanator…
machikoyasuda 52e9a78
refactor(base): put headline, explanatory, inner-content in 1 div, al…
machikoyasuda baa0e84
refactor(index): remove the term 'landing' and use base instead, like…
machikoyasuda 2597f54
refactor(logged-out): use inner-content instead of main-content
machikoyasuda 937295f
refactor(base): remove unnecessary class, col-12
machikoyasuda 9ff63af
chore: make messages
machikoyasuda 607423b
chore: make messages again
machikoyasuda 3361783
fix(elig-confirm): remove now unnecessary parent divs
machikoyasuda 5a4b47f
refactor(elig-index): remove now unnecessary block
machikoyasuda ca93e1b
refactor(base): remove explanatory-text block
machikoyasuda 0b5cb95
fix(error): remove extra col-md-6
machikoyasuda 6962659
reCAPTCHA: Spacing and template refactor (#2588)
machikoyasuda 9c8856f
Merge branch 'main' into refactor/recaptcha-copy
machikoyasuda 6efa48e
fix(success): remove unused block
machikoyasuda ae1ecfc
fix(form): move form class call to the container; refactor admin css
machikoyasuda e966125
fix(admin): add 1rem margins/gaps
machikoyasuda c44320c
fix(aria): remove unnecessary redundant aria form declaration
machikoyasuda 5bd26e9
refactor(admin): create css class for in person form styles to encapu…
machikoyasuda b9331eb
refactor(elig-verif): use eligveriform class to style the fields have…
machikoyasuda 9c521cf
Fix: reCAPTCHA-related - Fix Admin form style regression (#2613)
machikoyasuda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<li> | ||
<h2 class="h3 pb-1"> | ||
{% block heading %} | ||
{% endblock heading %} | ||
</h2> | ||
{% block body %} | ||
{% endblock body %} | ||
</li> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{% load i18n %} | ||
|
||
<p class="form-text text-body mt-0"> | ||
{% blocktranslate trimmed %} | ||
This site is protected by reCAPTCHA and the Google <a href="https://policies.google.com/privacy" target="_blank" rel="noopener noreferrer">Privacy Policy</a> and <a href="https://policies.google.com/terms" target="_blank" rel="noopener noreferrer">Terms of Service</a> apply. | ||
{% endblocktranslate %} | ||
</p> |
2 changes: 1 addition & 1 deletion
2
...its/core/templates/core/agency-index.html → ...re/templates/core/index--agency-base.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{% extends "core/landing.html" %} | ||
{% extends "core/index-base.html" %} | ||
{% load i18n %} | ||
|
||
{% block title %} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{% extends "core/landing.html" %} | ||
{% extends "core/index-base.html" %} | ||
{% load i18n %} | ||
|
||
{% block title %} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
...eligibility/templates/eligibility/includes/eligibility-item--contactless-card--start.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{% extends "core/includes/eligibility-item.html" %} | ||
{% load i18n %} | ||
|
||
{% block heading %} | ||
{% translate "Your contactless card details" %} | ||
{% endblock heading %} | ||
|
||
{% block body %} | ||
<p> | ||
{% translate "Your contactless card must be a debit or credit card by Visa or Mastercard." %} | ||
{% translate "Learn more about contactless cards" as text %} | ||
{% include "core/includes/modal-trigger.html" with modal="modal--contactless" text=text period=True %} | ||
</p> | ||
|
||
{% include "eligibility/includes/modal--contactless.html" with id="modal--contactless" size="modal-lg" header="p-md-2 p-3" body="pb-md-3 mb-md-3 mx-md-3 py-0 pt-0 absolute-top" %} | ||
{% endblock body %} |
11 changes: 11 additions & 0 deletions
11
...plates/eligibility/includes/eligibility-item--identification--start--cst-agency-card.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{% extends "core/includes/eligibility-item.html" %} | ||
|
||
{% load i18n %} | ||
|
||
{% block heading %} | ||
{% translate "Your current Agency Card number" %} | ||
{% endblock heading %} | ||
|
||
{% block body %} | ||
<p>{% translate "You do not need to have your physical CST Agency Card, but you will need to know the number." %}</p> | ||
{% endblock body %} |
23 changes: 23 additions & 0 deletions
23
...ty/templates/eligibility/includes/eligibility-item--identification--start--login-gov.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{% extends "core/includes/eligibility-item.html" %} | ||
|
||
{% load i18n %} | ||
|
||
{% block heading %} | ||
{% translate "A Login.gov account with identity verification" %} | ||
{% endblock heading %} | ||
|
||
{% block body %} | ||
<p> | ||
{% translate "You will be able to create an account using your email address if you do not already have one. We use your Login.gov account to verify your identity." %} | ||
{% translate "Learn more about identity verification" as text %} | ||
{% include "core/includes/modal-trigger.html" with modal="modal--identity-verification" text=text period=True %} | ||
</p> | ||
<p>{% translate "For this process you will need:" %}</p> | ||
<ul class="list-disc ms-lg-5 ms-0"> | ||
<li>{% translate "Your state-issued ID card" %}</li> | ||
<li>{% translate "Your Social Security number" %}</li> | ||
<li>{% translate "A phone number with a phone plan associated with your name" %}</li> | ||
</ul> | ||
|
||
{% include "eligibility/includes/modal--login-gov-start-help.html" with size="modal-lg" id="modal--identity-verification" header="p-md-2 p-3" body="pb-md-3 mb-md-3 mx-md-3 py-0 pt-0 absolute-top" %} | ||
{% endblock body %} |
13 changes: 13 additions & 0 deletions
13
...ity/templates/eligibility/includes/eligibility-item--identification--start--medicare.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{% extends "core/includes/eligibility-item.html" %} | ||
|
||
{% load i18n %} | ||
|
||
{% block heading %} | ||
{% translate "An online account with Medicare.gov" %} | ||
{% endblock heading %} | ||
|
||
{% block body %} | ||
<p> | ||
{% translate "If you do not have an account you will be able to create one using your red, white, and blue Medicare card. We use your Medicare.gov account to verify you qualify." %} | ||
</p> | ||
{% endblock body %} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏
This went from really complicated to really clean 👍