Fix: Use same Bootstrap version for both Admin and Benefits #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
front-end
Coverage report
This PR does not seem to contain any modification to coverable code. |
angela-tran
approved these changes
Dec 2, 2024
|
I noticed in dev-benefits.calitp.org that the skip link is showing even though I haven't pressed Tab or anything: I don't see this locally though: Will create a separate bug ticket for this |
lalver1
approved these changes
Dec 3, 2024
thekaveman
added this to the Benefits app frontend enhancements and optimization milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2551
The #2491 PR made a regression on Admin, by changing this line in the settings CSP: https://github.com/cal-itp/benefits/pull/2526/files#diff-d71405aa44f1e899a9cd920e5187aa1d02affdbd0da472eca95f814b0a8c1210R357, which then made the Bootstrap CSS version used on Admin inaccessible.
This PR:
QA:
I've now realized that #2491 introduced a few small changes (mostly deleting style declarations no longer necessary, that were overriding CA State Web Template) to the Button CSS in the Benefits app stylesheet, but not Admin's Button CSS - which had copied Benefits' CSS. This PR is not attempting to bring in those changes from Benefits CSS to Admin CSS. It's still a little weird that the two files' Button CSS are now diverging, and I think that can be done in a future clean up ticket.