Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: analytics for PaymentProcessor #2391

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Refactor: analytics for PaymentProcessor #2391

merged 3 commits into from
Sep 25, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Sep 20, 2024 •
edited
Loading

Part of #2249

  • Analytics event started payment connection renamed to started card tokenization
  • Analytics event closed payment connection renamed to ended card tokenization
  • Analytics event property payment_group renamed to enrollment_group
  • Updated docs

@lalver1 lalver1 self-assigned this Sep 20, 2024
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates documentation [auto] Improvements or additions to documentation back-end Django views, sessions, middleware, models, migrations etc. and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Sep 20, 2024
@github-actions GitHub Actions
Copy link

Preview url: https://benefits-2391--cal-itp-previews.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/enrollment
  analytics.py 16, 40
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman mentioned this pull request Sep 21, 2024
Merged
10 tasks
@lalver1 lalver1 force-pushed the refactor/paymentprocessor-amplitude branch from aa83625 to 40be0b9 Compare September 24, 2024 14:19
@lalver1 lalver1 marked this pull request as ready for review September 24, 2024 14:39
@lalver1 lalver1 requested a review from a team as a code owner September 24, 2024 14:39
thekaveman
thekaveman approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lalver1 lalver1 merged commit 16f1c80 into main Sep 25, 2024
17 checks passed
@lalver1 lalver1 deleted the refactor/paymentprocessor-amplitude branch September 25, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@thekaveman thekaveman thekaveman approved these changes

Assignees

@lalver1 lalver1

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev documentation [auto] Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lalver1 @thekaveman @machikoyasuda