Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: success template for in-person enrollment #2378

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Feat: success template for in-person enrollment #2378

merged 2 commits into from
Sep 20, 2024

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Sep 19, 2024 •
edited
Loading

Closes #2244

This PR implements in_person/success.html, completing the happy path for in-person enrollment.

image

@angela-tran angela-tran self-assigned this Sep 19, 2024
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Sep 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/in_person
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@angela-tran angela-tran marked this pull request as ready for review September 19, 2024 19:14
@angela-tran angela-tran requested a review from a team as a code owner September 19, 2024 19:14
thekaveman
thekaveman previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed, looks great

image

@angela-tran angela-tran force-pushed the feat/success-in-person-enrollment branch from f599067 to c3292aa Compare September 19, 2024 23:03
@angela-tran
Copy link
Member Author

Sorry @thekaveman , I ended up having to rebase to resolve merge conflicts with admin/styles.css 😓

@angela-tran angela-tran merged commit bfe2ad4 into main Sep 20, 2024
15 checks passed
@angela-tran angela-tran deleted the feat/success-in-person-enrollment branch September 20, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
Admin tool: in-person eligibility ver...
Development

Successfully merging this pull request may close these issues.

Implement enrollment view and template
2 participants
@angela-tran @thekaveman