Medicare: Eligibility Index - Modal and Radio Button Label #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
front-end
Coverage report
This PR does not seem to contain any modification to coverable code. |
machikoyasuda
commented
Sep 12, 2024
| "system_name": "senior", | ||
| "label": "(CST) Medicare Discount", | ||
| "group_id": "group123", | ||
| "enrollment_success_template": "enrollment/success--cst.html", |
There was a problem hiding this comment.
As long as we don't need to show the Sign out link, this enrollment success template is sufficient.
machikoyasuda
force-pushed
the
feat/2351-medicare-modal
branch
from
3d31199 to
cd8f10e
Compare
thekaveman
requested changes
Sep 16, 2024
| "group_id": "group123", | ||
| "enrollment_success_template": "enrollment/success--cst.html", | ||
| "display_order": 1, | ||
| "claims_provider": 1, |
There was a problem hiding this comment.
Since we will need a new ClaimsProvider for this pathway, can you please create one now in this PR?
Maybe change the client_name of the existing one to something like benefits-logingov and then create a new one benefits-medicaregov.
|
@machikoyasuda do we want to wait for Spanish translations for this PR, or would you rather merge and come back to that? |
machikoyasuda
force-pushed
the
feat/2351-medicare-modal
branch
from
cd8f10e to
9270c33
Compare
|
@thekaveman @lalver1 updated with new claims provider. ready for re-review. going to make a new ticket for this sprint for the Spanish translations. |
machikoyasuda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2351
closes #2350
closes #2358
What this PR does
How to test
To get the new fixture and copy: