Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: enrollment token logic #2348

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Conversation

angela-tran
Copy link
Member

Part of #2244

Extracts logic from benefits.enrollment.token view into benefits.enrollment.enrollment module. This is needed for the in-person enrollment view.

Similar to #2338

Testing locally

There shouldn't be any regressions with enrollment in the Benefits app.

@angela-tran angela-tran self-assigned this Sep 10, 2024
@angela-tran angela-tran requested a review from a team as a code owner September 10, 2024 23:45
@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/enrollment
  enrollment.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One hopefully small request

benefits/enrollment/enrollment.py Outdated Show resolved Hide resolved
benefits/enrollment/enrollment.py Outdated Show resolved Hide resolved
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@angela-tran angela-tran merged commit 99500c8 into main Sep 11, 2024
15 checks passed
@angela-tran angela-tran deleted the refactor/enrollment-token branch September 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants