-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: enrollment token logic #2348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
Related to automated testing (unit, UI, integration, etc.)
back-end
Django views, sessions, middleware, models, migrations etc.
deployment-dev
[auto] Changes that will trigger a deploy if merged to dev
labels
Sep 10, 2024
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
thekaveman
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One hopefully small request
thekaveman
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
back-end
Django views, sessions, middleware, models, migrations etc.
deployment-dev
[auto] Changes that will trigger a deploy if merged to dev
tests
Related to automated testing (unit, UI, integration, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2244
Extracts logic from
benefits.enrollment.token
view intobenefits.enrollment.enrollment
module. This is needed for the in-person enrollment view.Similar to #2338
Testing locally
There shouldn't be any regressions with enrollment in the Benefits app.