Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create medicare-cardholders use case #2306

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Conversation

indexing
Copy link
Member

  • Adding new page for Medicare cardholders use case

- Adding new page for Medicare cardholders use case
@indexing indexing requested a review from a team as a code owner August 14, 2024 22:34
@github-actions github-actions bot added the documentation [auto] Improvements or additions to documentation label Aug 14, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link

@indexing
Copy link
Member Author

@thekaveman It seems I need to create this file first before adding content? The syntax for my Mermaid diagram, for example, isn't recognized when I added content to the file.

@machikoyasuda
Copy link
Member

@indexing I think you are missing the file extension .md at the end of the file

image

indexing and others added 2 commits August 14, 2024 17:29
- added the .md extension to the filename (face palm)
- added Mermaid diagram
- added use case content
@machikoyasuda
Copy link
Member

Hey @indexing - The document looks great. This is the link to the preview: https://benefits-2306--cal-itp-previews.netlify.app/

As you can see, the sidebar title styles are not aligned:
image

I think it should be something like:

Introduction
Agency cardholders
Low-income
Medicare cardholders
Older adults
Veterans

The weird one is the Low-income adjective because it's not a noun/a name of a person like all the others. But we can leave that be. I think the Agency cardholders and Medicare cardholders titles should be formatted that way, and leave the use case part out.

The term use case here is a little confusing because there's this whole other Use cases section in the Product and design area: https://benefits-2306--cal-itp-previews.netlify.app/product-and-design/use-cases/enrollment-use-cases/

image

@indexing indexing self-assigned this Aug 15, 2024
@indexing indexing changed the title Create medicare-cardholders Create medicare-cardholders use case Aug 15, 2024
- removed "use case" suffix so title aligns with other use cases
@machikoyasuda
Copy link
Member

@indexing This change looks good to me. Maybe this PR can go out at the same time? #2253 The product and design phases are in progress now.

@machikoyasuda machikoyasuda self-requested a review August 15, 2024 19:18
@indexing indexing merged commit 6431615 into main Aug 16, 2024
12 checks passed
@indexing indexing deleted the indexing-medicare-use-case branch August 16, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [auto] Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants