Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: terraform source control block #2141

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

thekaveman
Copy link
Member

Closes #2118

How to test

  1. Get this branch locally
  2. Initialize terraform locally for dev
  3. terraform plan
  4. Verify output: No changes. Your infrastructure matches the configuration.

@thekaveman thekaveman requested a review from a team as a code owner June 5, 2024 21:57
@github-actions github-actions bot added the infrastructure Terraform, Azure, etc. label Jun 5, 2024
@thekaveman thekaveman self-assigned this Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman force-pushed the fix/terraform-source-control branch from 2148058 to 3475831 Compare June 5, 2024 22:00
@thekaveman thekaveman changed the base branch from dev to refactor/delete-refresh-config June 5, 2024 22:00
don't need the github_action_configuration, but removing this
dropped the DOCKER_REGISTRY_SERVER_URL setting, so adding it back
this is always re-added by plan/apply, so apparently it isn't saved anyway
@thekaveman thekaveman force-pushed the fix/terraform-source-control branch from 3475831 to 77c4981 Compare June 5, 2024 22:01
Base automatically changed from refactor/delete-refresh-config to dev June 6, 2024 19:08
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@thekaveman thekaveman merged commit 20aeaa1 into dev Jun 6, 2024
9 checks passed
@thekaveman thekaveman deleted the fix/terraform-source-control branch June 6, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Terraform, Azure, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Terraform config for new deployment setup
2 participants