Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: enrollment index update copy #2047

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Feat: enrollment index update copy #2047

merged 2 commits into from
Apr 25, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Apr 22, 2024 •
edited
Loading

Closes #2014

This PR updates the enrollment/index copy as shown in Figma.

Desktop

Before (using test-benefits) After (this branch) Figma
image image image

Mobile

Before (using test-benefits) After (this branch) Figma
image image image

@lalver1 lalver1 self-assigned this Apr 22, 2024
@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Apr 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@lalver1 lalver1 marked this pull request as ready for review April 23, 2024 15:46
@lalver1 lalver1 requested a review from a team as a code owner April 23, 2024 15:46
thekaveman
thekaveman requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor change requested

benefits/enrollment/templates/enrollment/index.html Outdated Show resolved Hide resolved
benefits/locale/es/LC_MESSAGES/django.po Show resolved Hide resolved
@lalver1 lalver1 force-pushed the feat/enrollment-index-copy branch from eb416a2 to 3f6b312 Compare April 25, 2024 21:44
@lalver1 lalver1 merged commit bbb81d4 into dev Apr 25, 2024
13 checks passed
@lalver1 lalver1 deleted the feat/enrollment-index-copy branch April 25, 2024 22:03
@thekaveman thekaveman mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@lalver1 lalver1

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
Digital Services
Status: Done
Milestone
Improved UX for agency card enrollment
Development

Successfully merging this pull request may close these issues.

Enrollment index: update copy to more clearly call out that contactless card is used for enrollment
2 participants
@lalver1 @thekaveman