Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: buttons #1562

Merged
merged 7 commits into from
Jul 25, 2023
Merged

Refactor: buttons #1562

merged 7 commits into from
Jul 25, 2023

Conversation

thekaveman
Copy link
Member

For #1442

@thekaveman thekaveman requested a review from a team as a code owner July 23, 2023 22:15
@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) i18n Copy: Language files or Django i18n framework back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed i18n Copy: Language files or Django i18n framework back-end Django views, sessions, middleware, models, migrations etc. labels Jul 23, 2023
@thekaveman thekaveman mentioned this pull request Jul 23, 2023
Closed
20 tasks
@thekaveman thekaveman self-assigned this Jul 23, 2023
@thekaveman thekaveman added the back-end Django views, sessions, middleware, models, migrations etc. label Jul 24, 2023
@thekaveman thekaveman enabled auto-merge July 24, 2023 20:44
@thekaveman thekaveman disabled auto-merge July 25, 2023 19:52
@thekaveman
Copy link
Member Author

Rebased on latest dev

angela-tran
angela-tran approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally. This looks great!

@thekaveman thekaveman merged commit 36a4dbf into dev Jul 25, 2023
@thekaveman thekaveman deleted the refactor/buttons branch July 25, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
UI composition improvements [eng]
Development

Successfully merging this pull request may close these issues.
2 participants
@thekaveman @angela-tran