Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Eligibility Index - Radio button alignment #1552

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Fix: Eligibility Index - Radio button alignment #1552

merged 1 commit into from
Jul 22, 2023

Conversation

machikoyasuda
Copy link
Member

closes #1545

The alignment logic:

  • Desktop and Tablet: The radio buttons have a 1 column offset (offset-lg-1)
  • Mobile: The radio buttons have a padding-left of 16px (ps-3), and no offset.

Desktop

image

Tablet

image image

Mobile

image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner July 21, 2023 17:03
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Jul 21, 2023
@machikoyasuda machikoyasuda self-assigned this Jul 21, 2023
@machikoyasuda machikoyasuda merged commit 67ee1a5 into dev Jul 22, 2023
@machikoyasuda machikoyasuda deleted the fix/1545-veterans-radio-button-alignment branch July 22, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eligibility Index: Small design issues
2 participants
@machikoyasuda @thekaveman