chore(Azure): remove app-level logging to Azure Monitor #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
back-end
|
Moving this to Draft state until we discuss at the next dev meeting. |
Wasn't working anyway.
Now that we have Sentry, we determined that the App Service logs are sufficient for other logs, and thus it isn't worth the complexity/confusion of having the logs sent to Azure Monitor.
afeld
force-pushed
the
chore/remove-azure-errors
branch
from
522d448 to
09a7bee
Compare
afeld
changed the title
|
Following the discussion at the dev workshop, determined logging to Azure Monitor wasn't worth the hassle. Expanded this pull request to remove the integration. Also updated the doc with the direct links. The App Service Logs will continue to be available. |
afeld
commented
Feb 16, 2023
| "propagate": False, | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
No change, just moved back into this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't working anyway. Alternative to #1260. Though this could be merged independently of #1259, we would likely only want to do so together so that we still have a system for error monitoring.