Docs updates #118
Merged
Docs updates #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekaveman
added
the
documentation
machikoyasuda
approved these changes
Sep 20, 2021
|
Thanks for the review @machikoyasuda! I'm going to wait to merge this until #114 is merged so we can test out that filter! |
|
I'll actually wait for #115 as well, so we can test both filters 😄 |
|
@thekaveman Update: Merged #115 - As expected, the Docs deploy action is not running. Now this PR is ready to roll! We should expect the Docs deploy to run, but the Dev deploy should not run.
Update, 2: Merging the Dev deploy PR successfully did not trigger the Docs PR!
|
|
@machiko awesome! I'm merging this one now... EDIT: success!! The dev deploy did not run, as expected!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117. Plus some other small cleanups and a new page describing the GitHub Actions deployment workflows in more detail.