Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Terraform): remove hostname bindings for dev and test slots #1166

Closed
wants to merge 1 commit into from

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Dec 21, 2022

They will be re-added when moved to the new App Service instances in #1074.

They will be re-added when moved to the new App Service instances.
@afeld afeld requested a review from a team as a code owner December 21, 2022 22:35
@github-actions github-actions bot added the infrastructure Terraform, Azure, etc. label Dec 21, 2022
@thekaveman
Copy link
Member

Sorry, what is the advantage/reason of doing this first/separately from #1074?

@angela-tran
Copy link
Member

Sorry, what is the advantage/reason of doing this first/separately from #1074?

My understanding is that Azure doesn't let you have the same hostname binding to multiple app services, so we have to unbind it from the dev slot first and then bind it to the separate dev instance.

@afeld
Copy link
Contributor Author

afeld commented Dec 21, 2022

I was mistaken; turns out the hostname can be bound to two App Service instances. No longer needed.

@afeld afeld closed this Dec 21, 2022
@afeld afeld deleted the chore/remove-dev-test-hosts branch December 21, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Terraform, Azure, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants