Fix: previous page button hover style #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will make the hover style easier to implement with a single icon move away from using the button include directly, simplify viewmodel to move HTML attributes to HTML
github-actions
bot
added
back-end
machikoyasuda
requested changes
Oct 12, 2022
|
@machikoyasuda thank you, updated in a21a376 |
machikoyasuda
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1040
Changing the implementation of
previous-page-button.htmlinclude to inline the SVG left arrow icon (exported from Figma) to make it easier to style on hover. Also simplified the viewmodel helper by moving most attributes to the include directly.Desktop
Regular
Hover
Mobile
Regular
Hover