Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new "start eligibility" view/URL #332

Closed
13 tasks done
Tracked by #317
thekaveman opened this issue Mar 18, 2022 · 0 comments · Fixed by #335
Closed
13 tasks done
Tracked by #317

Add a new "start eligibility" view/URL #332

thekaveman opened this issue Mar 18, 2022 · 0 comments · Fixed by #335
Assignees

Comments

@thekaveman
Copy link
Member

thekaveman commented Mar 18, 2022

This replaces what the current eligibility:index view is doing, which will transition to displaying the verifier selection form in #322.

Depends on #319, #323

  • Rename the instructions_* fields from Update EligiblityVerifier model to support custom text content #319 to start_* to align with the simplification in this task
    • models
    • migrations
    • fixtures
  • Update *.po files with a new keys eligibility.pages.start.*, copy the value from eligibility.pages.index.* (for now)
  • Create view function named start
    • Add an AgencySessionRequired middleware decorator to this view
    • Add a VerifierSessionRequired middleware decorator to this view
  • Create a URL route /eligibility/start to this view
  • In the view:
    • Read from session the selected verifier
    • Create a Page viewmodel using a mix of the common keys and the verifier-specific keys for text translations
    • Send the viewmodel to the template with the PageTemplateResponse helper
@thekaveman thekaveman changed the title Add a new view function like eligibility:instructions that reads from session the selected verifier and renders their specific instructions in a template Add a new "eligibility start" view/URL Mar 18, 2022
@thekaveman thekaveman changed the title Add a new "eligibility start" view/URL Add a new "start eligibility" view/URL Mar 18, 2022
@thekaveman thekaveman added this to the Courtesy Cards milestone Mar 18, 2022
@thekaveman thekaveman moved this to This Sprint in Digital Services Mar 18, 2022
@thekaveman thekaveman moved this from This Sprint to Blocked in Digital Services Mar 18, 2022
@thekaveman thekaveman self-assigned this Mar 21, 2022
@thekaveman thekaveman moved this from Blocked to In Progress in Digital Services Mar 21, 2022
@thekaveman thekaveman moved this from In Progress to PR Open in Digital Services Mar 22, 2022
Repository owner moved this from PR Open to Done in Digital Services Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant