Allow setting globals, back off of dict-likeness #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting and deleting globals. I decided to make the object look less like a `dict` to avoid confusing people. Code like this would not work as expected: s["x"] = [1,2,3] s["x"][1] = 7 This is because subcripting the object converts the starlark.Value to its Python equivalent and then returns it. Subsequent modifications to the object it returns aren't reflected back to Starlark, though. So hopefully by avoiding looking too much like a `dict`, we'll prevent users from getting confused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting and deleting globals. I decided to make the object look
less like a
dictto avoid confusing people. Code like this wouldnot work as expected:
s["x"] = [1,2,3]
s["x"][1] = 7
This is because subcripting the object converts the starlark.Value to
its Python equivalent and then returns it. Subsequent modifications to
the object it returns aren't reflected back to Starlark, though. So
hopefully by avoiding looking too much like a
dict, we'll preventusers from getting confused.