Make builtin the default migrations backend #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 4.3 branch has been out for a few months and there haven't been any showstopping bugs reported yet. Changing the default backend to builtin and retaining the phinx backend as an escape hatch until a fix can be released seems like a decent compromise on moving forwards and retaining compatibility.
othercorey
reviewed
Aug 19, 2024
| @@ -80,6 +80,7 @@ public function buildOptionParser(ConsoleOptionParser $parser): ConsoleOptionPar | |||
| 'help' => "Mark any migrations selected as run, but don't actually execute them", | |||
| 'boolean' => true, | |||
| ])->addOption('dry-run', [ | |||
| 'short' => 'x', | |||
There was a problem hiding this comment.
Was this change intentional?
There was a problem hiding this comment.
Yes. I missed this short alias and the tests for CompletionShell integration identified the regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 4.3 branch has been out for a few months and there haven't been any showstopping bugs reported yet. Changing the default backend to builtin and retaining the phinx backend as an escape hatch until a fix can be released seems like a decent compromise on moving forwards and retaining compatibility.