Add message if migrations/seeds folders do not exist and debug is dis… #584
Conversation
| if (!is_dir($migrationsPath)) { | ||
| if (!Configure::read('debug')) { | ||
| throw new \RuntimeException(sprintf( | ||
| 'Migrations path `%s` does not exist and cannot be created because `debug` is disabled.', |
There was a problem hiding this comment.
Thats not the reason imo
Better to output that path needs to exist
No one should enable debug on prod
There was a problem hiding this comment.
Indeed it will never happen in prod because when code reaches prod the Migrations folder will exist. The problem happens when somebody disables debug in local environment and tries to create a migration
There was a problem hiding this comment.
@dereuromark this check works great if you are only using migrations but the seeds directory must exist now because of the check below to make sure the seeds directory exists. L96-L102
|
These tests are now failing after the merge. |
|
I think this PR is now causing issues with plugins that have migrations but don't have |
|
This is also happening with https://github.com/CakeDC/users/ since it too does not have a |
|
Can you create a new issue to track this |
Fixes #565
Adds a message if
debugis disabled and folders do not exist.Adds more tests to ConfigurationTrait.