-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #500 . If precision is 0 command adds it anyway. #562
Fixes #500 . If precision is 0 command adds it anyway. #562
Conversation
… and already initialized property
@ADmad Same situation than #561 psalm reports:
If you have any clue about how to fix it, it is more than welcome :) See #561 (comment) |
When I've run into this in the past it was the |
Hey @markstory, yes it may fix the issue as well, I've fixed changing coding standards php to 7.2 per Admad's recommendation and it worked. However if you prefer increasing php requirements to 7.4 I can make that change. Thanks you! |
I think that's a safe change to make as 4.4 also requires php7.4. |
595d098
to
8a1ea70
Compare
…kephp-migrations into issue/500-decimal-no-precision
Looks good! |
Changing empty to is_null avoids ignoring decimal(X,0) and snapshot is generated correctly. Fixes #500