Merge pull request #579 from cakephp/remove-pdo

Remove unnecessary Connection pdo manipulation
cakephp · Oct 14, 2022 · e1a0a76 · e1a0a76
2 parents 1be4a10 + 88ca712
commit e1a0a76
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 11 deletions.
diff --git a/tests/TestCase/Command/Phinx/CacheBuildTest.php b/tests/TestCase/Command/Phinx/CacheBuildTest.php
@@ -68,7 +68,6 @@ public function tearDown(): void
         Cache::disable();
         $this->connection->cacheMetadata(false);
         $this->connection->execute('DROP TABLE IF EXISTS blog');
-        unset($this->connection, $this->command, $this->streamOutput);
     }
 
     /**

diff --git a/tests/TestCase/Command/Phinx/CacheClearTest.php b/tests/TestCase/Command/Phinx/CacheClearTest.php
@@ -66,7 +66,6 @@ public function tearDown(): void
         Cache::disable();
         $this->connection->cacheMetadata(false);
         $this->connection->execute('DROP TABLE IF EXISTS blog');
-        unset($this->connection, $this->command, $this->streamOutput);
     }
 
     /**

diff --git a/tests/TestCase/Command/Phinx/CreateTest.php b/tests/TestCase/Command/Phinx/CreateTest.php
@@ -69,8 +69,6 @@ public function setUp(): void
     public function tearDown(): void
     {
         parent::tearDown();
-        unset($this->connection, $this->command, $this->streamOutput);
-
         foreach ($this->generatedFiles as $file) {
             if (file_exists($file)) {
                 unlink($file);

diff --git a/tests/TestCase/Command/Phinx/DumpTest.php b/tests/TestCase/Command/Phinx/DumpTest.php
@@ -97,13 +97,10 @@ public function setUp(): void
     public function tearDown(): void
     {
         parent::tearDown();
-
-        $this->connection->getDriver()->setConnection($this->pdo);
         $this->connection->execute('DROP TABLE IF EXISTS phinxlog');
         $this->connection->execute('DROP TABLE IF EXISTS numbers');
         $this->connection->execute('DROP TABLE IF EXISTS letters');
         $this->connection->execute('DROP TABLE IF EXISTS parts');
-        unset($this->connection, $this->command, $this->streamOutput);
     }
 
     /**

diff --git a/tests/TestCase/Command/Phinx/MarkMigratedTest.php b/tests/TestCase/Command/Phinx/MarkMigratedTest.php
@@ -80,10 +80,8 @@ public function setUp(): void
     public function tearDown(): void
     {
         parent::tearDown();
-        $this->connection->getDriver()->setConnection($this->pdo);
         $this->connection->execute('DROP TABLE IF EXISTS phinxlog');
         $this->connection->execute('DROP TABLE IF EXISTS numbers');
-        unset($this->connection, $this->commandTester, $this->command);
     }
 
     /**

diff --git a/tests/TestCase/Command/Phinx/SeedTest.php b/tests/TestCase/Command/Phinx/SeedTest.php
@@ -79,10 +79,8 @@ public function setUp(): void
     public function tearDown(): void
     {
         parent::tearDown();
-        $this->connection->getDriver()->setConnection($this->pdo);
         $this->connection->execute('DROP TABLE IF EXISTS phinxlog');
         $this->connection->execute('DROP TABLE IF EXISTS numbers');
-        unset($this->connection, $this->command, $this->streamOutput);
     }
 
     /**