Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo: AccociateTag -> AssociateTag #50

Closed

Conversation

angelxmoreno
Copy link
Contributor

Was getting a "Missing Parameters" error saying "Your request is missing required parameters. Required parameters include AssociateTag". Noticed there was a typo that was fixed in the master branch but no in the 2.3 branch.

@angelxmoreno
Copy link
Contributor Author

I noticed that making the change of spelling within AmazonAssociatesTestCase generates a different signature. This is because the signature is generated using the keys and values used in the query. Changing the spelling of a key would render a different signature.
So, that being said, I can either put the misspelled key back in the TestCase or I can replace the old signature with a new one. The problem with the latter is that I can not find a reliable way to generate the signature that is outside of the class itself. It feels a bit odd to use a method to generate a string and then test to see if it makes that string.

Any suggestions on how I should proceed?

Conflicts:
	Model/Datasource/AmazonAssociatesSource.php
@angelxmoreno
Copy link
Contributor Author

great news! i found http://associates-amazon.s3.amazonaws.com/signed-requests/helper/index.html so basically i can put in the params the testCase is using and it will generate a realiable signature i can compare to. updating my code soon,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants