Switch to using the phpcs provided uppercase constant sniff. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen a few builds fail because return type values are being caught by our sniff. After reviewing the one in PHPCS it seems to capture all the cases we care about so there is no reason to continue maintaining our own version.
dereuromark
reviewed
Jun 7, 2018
CakePHP/ruleset.xml
Outdated
| @@ -111,6 +112,7 @@ | |||
| <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/> | |||
| <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/> | |||
| <rule ref="Squiz.WhiteSpace.ScopeClosingBrace"/> | |||
| <rule ref="Generic.NamingConventions.UpperCaseConstant"/> | |||
There was a problem hiding this comment.
Invalid name, should be UpperCaseConstantName
There was a problem hiding this comment.
Blerg sorry about that.
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
===========================================
+ Coverage 85.52% 86.92% +1.4%
+ Complexity 293 263 -30
===========================================
Files 23 22 -1
Lines 815 719 -96
===========================================
- Hits 697 625 -72
+ Misses 118 94 -24Continue to review full report at Codecov.
|
|
I fixed the sniff name. |
|
Will you make a patch release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a few builds fail because return type values are being caught by our sniff. After reviewing the one in PHPCS it seems to capture all the cases we care about so there is no reason to continue maintaining our own version.