Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x: use plugin loading via configuration array #971

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Conversation

LordSimal
Copy link
Contributor

I really like the new plugin loading functionality via config/plugins.php.

This allows the Application class to be pretty clean.

@LordSimal LordSimal added this to the 5.x milestone Sep 15, 2023
@LordSimal
Copy link
Contributor Author

Seems weird that the DebugKit is not being loaded in the tests...

@LordSimal
Copy link
Contributor Author

Ah, we do a include_once here but these tests require that this file can be loaded multiple times in the same PHP process.

@ADmad
Copy link
Member

ADmad commented Sep 15, 2023

Thanks, this was my final goal, just never got around to finishing it :)

I eventually want plugin installing and enabling to be a single command process, not the 2 steps of composer install and bin/cake plugin load.

@LordSimal
Copy link
Contributor Author

I eventually want plugin installing and enabling to be a single command process

yes, that would be the best scenario

@markstory
Copy link
Member

I like the approach of using config/plugins.php more consistently 👍

@LordSimal
Copy link
Contributor Author

LordSimal commented Sep 30, 2023

To get 8.1 lowest working here we would have to adjust the composer.json to "cakephp/cakephp": "^5.0.1",

@markstory markstory merged commit b335138 into 5.x Sep 30, 2023
@markstory markstory deleted the 5.x-plugins-config branch September 30, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants