Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x fix stan #933

Merged
merged 4 commits into from
Jan 6, 2023
Merged

5.x fix stan #933

merged 4 commits into from
Jan 6, 2023

Conversation

LordSimal
Copy link
Contributor

This PR contains the commit from #932 so CI can actually run.

Due to the recent merge of generics annotations in cakephp/cakephp#16891 this of course introduced some psalm problems here, but nothing too major.

@LordSimal LordSimal added this to the 5.x milestone Jan 5, 2023
composer.json Outdated
@@ -14,7 +14,7 @@
"require-dev": {
"cakephp/bake": "dev-cake5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be updated too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I missed that one 😄
seems that packagist cached that version string

@ADmad ADmad merged commit 4b54baa into 5.x Jan 6, 2023
@ADmad ADmad deleted the 5.x-fix-stan branch January 6, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants