Make tests stable against debug mode. #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is resolved at CakePHP 3.6.3. Remove a test added at ec4b498. Refs cakephp#893
Run testDisplay in debug mode. Pages in this repo can only be displayed in debug mode. Do not assert normal responses at testCsrfAppliedOk. Responses may change by debug mode, but that is not a concern of this test. Assert the opposite of testCsrfAppliedError. Refs cakephp#893
Make testBootstrap run in production mode, and add a case to test bootstrap in debug mode. DebugKit should not be added in production, but should be added in debug mode. Refs cakephp#893
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893