Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Cake\Codeception\Console\Installer #862

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Import Cake\Codeception\Console\Installer #862

merged 2 commits into from
Oct 13, 2021

Conversation

szepeviktor
Copy link
Contributor

Minus one variable 🚀

@szepeviktor szepeviktor marked this pull request as draft October 13, 2021 02:16
@szepeviktor szepeviktor marked this pull request as ready for review October 13, 2021 02:17
@ADmad ADmad merged commit 5818a80 into cakephp:master Oct 13, 2021
@szepeviktor
Copy link
Contributor Author

Thank you.

@szepeviktor szepeviktor deleted the patch-2 branch October 13, 2021 02:40
@othercorey
Copy link
Member

Should we even suggest this anymore?

@ADmad
Copy link
Member

ADmad commented Oct 13, 2021

Probably not, the codeception plugin isn't maintained.

@LordSimal
Copy link
Contributor

The class Cake\Codeception\Console\Installer doesn't seem to exist for me. I am on CakePHP 4.3.
Or am I missing something?

@ndm2
Copy link
Contributor

ndm2 commented Nov 6, 2021

It's in the codeception plugin.

@LordSimal
Copy link
Contributor

I was just confused to see code/use statements which are not resolvable in the "base" app template because the plugin is not in the composer.json

If this is intended then forget that I asked 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szepeviktor @othercorey @ADmad @LordSimal @ndm2