Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW-898 fix fast scanner #1957

Merged
merged 10 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/view_model/node_list/node_create_or_edit_view_model.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'package:cake_wallet/core/execution_state.dart';
import 'package:cake_wallet/entities/qr_scanner.dart';
import 'package:cake_wallet/store/settings_store.dart';
import 'package:cw_core/utils/print_verbose.dart';
import 'package:flutter/cupertino.dart';
import 'package:hive/hive.dart';
import 'package:mobx/mobx.dart';
Expand Down Expand Up @@ -215,7 +216,6 @@ abstract class NodeCreateOrEditViewModelBase with Store {
await PermissionHandler.checkPermission(Permission.camera, context);
if (!isCameraPermissionGranted) return;
String code = await presentQRScanner(context);

if (code.isEmpty) {
throw Exception('Unexpected scan QR code value: value is empty');
}
Expand All @@ -228,12 +228,12 @@ abstract class NodeCreateOrEditViewModelBase with Store {
}

final userInfo = uri.userInfo;
final rpcUser = userInfo.length == 2 ? userInfo[0] : '';
final rpcPassword = userInfo.length == 2 ? userInfo[1] : '';
final ipAddress = uri.host;
final port = uri.hasPort ? uri.port.toString() : '';
final path = uri.path;
final queryParams = uri.queryParameters; // Currently not used
final rpcUser = userInfo.split(':').first;
final rpcPassword = userInfo.split(':').length > 1 ? userInfo.split(':')[1] : '';

await Future.delayed(Duration(milliseconds: 345));

Expand Down
2 changes: 1 addition & 1 deletion pubspec_base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies:
fast_scanner:
git:
url: https://github.com/MrCyjaneK/fast_scanner
ref: c5a08720216a508bf1fe3d062ad19d2836545a42
ref: 69b3276b090fa6ac01b4483ca3adca93a8e615be
http: ^1.1.0
path_provider: ^2.0.11
mobx: ^2.1.4
Expand Down
Loading