Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for resolving unofficial .net core kudu tool #20

Closed
AdmiringWorm opened this issue Sep 3, 2020 · 0 comments
Closed

Add support for resolving unofficial .net core kudu tool #20

AdmiringWorm opened this issue Sep 3, 2020 · 0 comments
Labels
enhancement
Milestone
0.11.0

Comments

@AdmiringWorm
Copy link
Member

Expected Behavior

Since there is an unofficial edition of kudu that is built with .NET Core (instead of .NET Framework) it would be nice if Cake.Kudu would support resolving the name this edition.

Current Behavior

Currently, only KuduSync.NET.exe is being taken into account when searching for the Kudu executable.

Possible Solution

Add support for resolving kudusync and kudusync.exe (possibly dotnet-kudusync/dotnet-kudusync.exe, but not sure if that is needed).

Context

This is in the context of using Cake.Recipe and building .NET Core projects, this will use the .NET Core edition of KuduSync instead of the official one, and thus making everything fail.

Your Environment

  • Module version used: 0.10.1
  • Operating System and PowerShell version: Windows Server 2019 (powershell version uncertain, possibly Core 7.0)
gep13 added a commit to gep13/Cake.Kudu that referenced this issue Sep 4, 2020
@gep13
(cake-contribGH-20) Add additional executable names
c939b13 
This will allow resolving the unofficial KuduSync.Tool executables.
@gep13 gep13 mentioned this issue Sep 4, 2020
Merged
9 tasks
devlead added a commit that referenced this issue Sep 10, 2020
@devlead
Merge pull request #21 from gep13/feature/GH-20
c2c7f1f 
(GH-20) Add additional executable names
@devlead devlead added this to the 0.11.0 milestone Sep 10, 2020
@devlead devlead closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@AdmiringWorm @devlead